Setup Support for delaying ChannelMonitorUpdate flight until an Event completes#2111
Merged
TheBlueMatt merged 4 commits intolightningdevkit:mainfrom May 4, 2023
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does all the work that will be required to pause
ChannelMonitorUpdateflight until anEventcompletes, but doesn't actually use the new behavior. Sadly, I think we should consider splitting this work across release, as the commitTrack an EventCompletionAction for after an Event is processedindicates -Still, I'm open to discussion on it -
Events generally should be reliably processed before a full round-trip happens, and it sucks to fix major bugs across releases just over worry of a hopefully-very-rare race breaking forwards, but not backwards, compat.